Re: [PATCH] btrfs: fix unbalanced unlock in qgroup_account_snapshot()
From: Qu Wenruo <hidden>
Date: 2021-06-21 01:33:48
Also in:
stable
On 2021/6/21 上午9:21, Naohiro Aota wrote:
qgroup_account_snapshot() is trying to unlock the not taken
tree_log_mutex in a error path. Since ret != 0 in this case, we can
just return from here.
Fixes: 2a4d84c11a87 ("btrfs: move delayed ref flushing for qgroup into qgroup helper")
Cc: stable <redacted> # 5.12
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>Reviewed-by: Qu Wenruo <redacted> Thanks, Qu
quoted hunk ↗ jump to hunk
--- fs/btrfs/transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index f75de9f6c0ad..6aca64cf77dc 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c@@ -1476,7 +1476,7 @@ static int qgroup_account_snapshot(struct btrfs_trans_handle *trans, ret = btrfs_run_delayed_refs(trans, (unsigned long)-1); if (ret) { btrfs_abort_transaction(trans, ret); - goto out; + return ret; } /*