Re: [PATCH] btrfs: abort the transaction if we fail to replay log trees
From: David Sterba <hidden>
Date: 2021-05-20 13:19:20
On Wed, May 19, 2021 at 04:22:33PM -0400, Josef Bacik wrote:
On 5/19/21 4:15 PM, David Sterba wrote:quoted
On Wed, May 19, 2021 at 04:22:20PM +0000, Johannes Thumshirn wrote:quoted
On 19/05/2021 17:29, Josef Bacik wrote:Good point and I want to keep the abort pattern consistent so it should be called before the goto error's. Note that this function still uses btrfs_handle_fs_error which predates the transaction abort framework and should be replaced as needed.Yeah this is a good point, I assume since we're now going to get the transaction abort message for the spots I replace btrfs_handle_fs_error() we don't need to replace the message? Thanks,
Yeah, plain btrfs_abort_transaction should be ok.