Thread (15 messages) 15 messages, 3 authors, 2021-05-03

Re: [PATCH] btrfs: add fstrim test case on the sprout device

From: Anand Jain <hidden>
Date: 2021-05-01 05:16:26
Also in: fstests 

quoted
+
+_mkfs_dev $seed
+_mount $seed $SCRATCH_MNT
Missing the check for discard/trim support:

_require_batched_discard $SCRATCH_MNT
  Oh. I will add.


quoted
+fstrim $SCRATCH_MNT
Should use $FSTRIM_PROG instead of fstrim.
  Right. Ok.


quoted
+
+_scratch_unmount
+_mount $seed $SCRATCH_MNT 2>&1 | _filter_scratch
+md5sum $SCRATCH_MNT/foo | _filter_scratch
+_scratch_unmount
Missing a call to _scratch_dev_pool_put
  Yep. I will add.


quoted hunk ↗ jump to hunk
Ok, it fails as expected without the btrfs fix.
But with the fix applied, it fails differently for me. It looks like
different mount versions output different strings maybe:
quoted
root 16:18:40 /home/fdmanana/git/hub/xfstests (master)> ./check btrfs/237
FSTYP         -- btrfs
PLATFORM      -- Linux/x86_64 debian8 5.12.0-rc8-btrfs-next-86 #1 SMP
PREEMPT Fri Apr 23 17:35:49 WEST 2021
MKFS_OPTIONS  -- /dev/sdc
MOUNT_OPTIONS -- /dev/sdc /home/fdmanana/btrfs-tests/scratch_1

btrfs/237 - output mismatch (see
/home/fdmanana/git/hub/xfstests/results//btrfs/237.out.bad)
     --- tests/btrfs/237.out 2021-04-30 16:09:33.103380077 +0100
     +++ /home/fdmanana/git/hub/xfstests/results//btrfs/237.out.bad
2021-04-30 16:19:31.577988213 +0100
     @@ -1,5 +1,5 @@
      QA output created by 237
     -mount: SCRATCH_MNT: WARNING: device write-protected, mounted read-only.
     +mount: SCRATCH_MNT: WARNING: source write-protected, mounted read-only.
      096003817ad2638000a6836e55866697  SCRATCH_MNT/foo
     -mount: SCRATCH_MNT: WARNING: device write-protected, mounted read-only.
     +mount: SCRATCH_MNT: WARNING: source write-protected, mounted read-only.
      096003817ad2638000a6836e55866697  SCRATCH_MNT/foo
     ...
     (Run 'diff -u /home/fdmanana/git/hub/xfstests/tests/btrfs/237.out
/home/fdmanana/git/hub/xfstests/results//btrfs/237.out.bad'  to see
the entire diff)
Ran: btrfs/237
Failures: btrfs/237
Failed 1 of 1 tests

root 16:19:31 /home/fdmanana/git/hub/xfstests (master)> diff -u
/home/fdmanana/git/hub/xfstests/tests/btrfs/237.out
/home/fdmanana/git/hub/xfstests/results//btrfs/237.out.bad
--- /home/fdmanana/git/hub/xfstests/tests/btrfs/237.out 2021-04-30
16:09:33.103380077 +0100
+++ /home/fdmanana/git/hub/xfstests/results//btrfs/237.out.bad
2021-04-30 16:19:31.577988213 +0100
@@ -1,5 +1,5 @@
  QA output created by 237
-mount: SCRATCH_MNT: WARNING: device write-protected, mounted read-only.
+mount: SCRATCH_MNT: WARNING: source write-protected, mounted read-only.
  096003817ad2638000a6836e55866697  SCRATCH_MNT/foo
-mount: SCRATCH_MNT: WARNING: device write-protected, mounted read-only.
+mount: SCRATCH_MNT: WARNING: source write-protected, mounted read-only.
  096003817ad2638000a6836e55866697  SCRATCH_MNT/foo
root 16:20:06 /home/fdmanana/git/hub/xfstests (master)>
  Just found there is _filter_ro_mount, which comes in handy here.
  I will use it.

Thanks, Anand


Thanks.

quoted
--
2.27.0
  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help