Thread (8 messages) 8 messages, 5 authors, 2021-05-17

Re: [PATCH] fs/btrfs: Fix uninitialized variable

From: Dan Carpenter <hidden>
Date: 2021-05-03 07:23:51
Also in: kernel-janitors, lkml

On Sat, May 01, 2021 at 11:50:46PM +0100, Khaled ROMDHANI wrote:
Fix the warning: variable 'zone' is used
uninitialized whenever '?:' condition is true.

Fix that by preventing the code to reach
the last assertion. If the variable 'mirror'
is invalid, the assertion fails and we return
immediately.

Reported-by: kernel test robot <redacted>
Signed-off-by: Khaled ROMDHANI <redacted>
---
This is not how you send a v4 patch...  v2 patches have to apply to the
original code and not on top of the patched code.

I sort of think you should find a different thing to work on.  This code
works fine as-is.  Just leave it and try to find a real bug and fix that
instead.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help