Thread (3 messages) 3 messages, 3 authors, 2021-03-25

Re: [PATCH] fstests: don't relay on /proc/partitions for device size

From: Nikolay Borisov <hidden>
Date: 2021-03-25 12:14:33
Also in: fstests


On 25.03.21 г. 13:23, Johannes Thumshirn wrote:
quoted hunk ↗ jump to hunk
Non-partitionable devices, like zoned block devices, aren't showing up in in
/proc/partitions and therefore we cannot relay on it to get a device's
size.

Use sysfs' size attribute to get the block device size.

Cc: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Johannes Thumshirn <redacted>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 1c814b9aabf1..c99fff824087 100644
--- a/common/rc
+++ b/common/rc
@@ -3778,7 +3778,7 @@ _get_available_space()
 # return device size in kb
 _get_device_size()
 {
-	grep -w `_short_dev $1` /proc/partitions | awk '{print $3}'
+	echo $(($(cat /sys/block/`_short_dev $1`/size) >> 1))
 }
How about simply using 'blockdev --getsz'
 
 # Make sure we actually have dmesg checking set up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help