Thread (4 messages) 4 messages, 4 authors, 2021-03-04

Re: [PATCH] btrfs-progs: add a warning label for RAID5/6

From: David Sterba <hidden>
Date: 2021-03-04 00:20:26

On Tue, Aug 25, 2020 at 12:51:02PM -0400, Josef Bacik wrote:
quoted hunk ↗ jump to hunk
We all know there's some dark and scary corners with RAID5/6, but users
may not know.  Add a warning message in mkfs so anybody trying to use
this will know things can go very wrong.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 mkfs/main.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/mkfs/main.c b/mkfs/main.c
index 0a4de617..0db24ad4 100644
--- a/mkfs/main.c
+++ b/mkfs/main.c
@@ -1183,6 +1183,8 @@ int BOX_MAIN(mkfs)(int argc, char **argv)
 	if ((data_profile | metadata_profile) &
 	    (BTRFS_BLOCK_GROUP_RAID5 | BTRFS_BLOCK_GROUP_RAID6)) {
 		features |= BTRFS_FEATURE_INCOMPAT_RAID56;
+		warning("RAID5/6 support is still experimental and has known "
+			"issues, do not rely on this for data you care about.\n");
I've reworded the message, calling it experimental after so many years
is a bit kappa. Also we'll need something in the docs for reference,
I'll write something.
 	}
 
 	if ((data_profile | metadata_profile) &
-- 
2.24.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help