Re: [PATCH v2] btrfs: rework the order of btrfs_ordered_extent::flags
From: David Sterba <hidden>
Date: 2021-02-10 23:36:38
On Tue, Jan 26, 2021 at 08:35:45AM +0800, Qu Wenruo wrote:
quoted hunk ↗ jump to hunk
--- a/fs/btrfs/ordered-data.h +++ b/fs/btrfs/ordered-data.h@@ -27,7 +27,7 @@ struct btrfs_ordered_sum { }; /* - * bits for the flags field: + * Bits for btrfs_ordered_extent::flags. * * BTRFS_ORDERED_IO_DONE is set when all of the blocks are written. * It is used to make sure metadata is inserted into the tree only once@@ -38,24 +38,36 @@ struct btrfs_ordered_sum { * IO is done and any metadata is inserted into the tree. */ enum { + /* + * Different types for ordered extent, one and only one of the 4 types + * can be set when creating ordered extent.
Sorry, I did not merge this followup in time for the 5.12 freeze and now it would be too late to rebase the whole branch just to fix a comment. The difference is 'types for direct io' and the 'the 4 type' (typo). Please send an incremental patch, the comment would be incorrect and is worth fixing. Thanks.