Thread (3 messages) 3 messages, 3 authors, 2021-01-27

Re: [PATCH] btrfs: remove wrong comment for can_nocow_extent()

From: Josef Bacik <josef@toxicpanda.com>
Date: 2021-01-27 15:30:28

On 1/27/21 10:05 AM, fdmanana@kernel.org wrote:
From: Filipe Manana <redacted>

The comment for can_nocow_extent() says that the function will flush
ordered extents, however that never happens and was never true before the
comment was added in commit e4ecaf90bc13 ("btrfs: add comments for
btrfs_check_can_nocow() and can_nocow_extent()"). This is true only for
the function btrfs_check_can_nocow(), which after that commit was renamed
to check_can_nocow(). So just remove that part of the comment.

Signed-off-by: Filipe Manana <redacted>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help