Thread (7 messages) 7 messages, 6 authors, 2021-01-30

Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig

From: Qu Wenruo <hidden>
Date: 2021-01-27 09:50:31
Also in: u-boot


On 2021/1/27 下午5:42, matthias.bgg@kernel.org wrote:
From: Matthias Brugger <mbrugger@suse.com>

Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
it. This leads to compilation errors:
fs/built-in.o: In function `hash_sha256':
fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Oh, forgot to select sha256.

Thanks for the fix.

Reviewed-by: Qu Wenruo <redacted>

Thanks,
Qu
quoted hunk ↗ jump to hunk
---

  fs/btrfs/Kconfig | 1 +
  1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index f302b1fbef..2a32f42ad1 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -4,6 +4,7 @@ config FS_BTRFS
  	select LZO
  	select ZSTD
  	select RBTREE
+	select SHA256
  	help
  	  This provides a single-device read-only BTRFS support. BTRFS is a
  	  next-generation Linux file system based on the copy-on-write
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help