Thread (11 messages) 11 messages, 5 authors, 2021-01-29

Re: [PATCH v2] btrfs: Avoid calling btrfs_get_chunk_map() twice

From: David Sterba <hidden>
Date: 2021-01-29 19:46:12
Also in: lkml

On Fri, Jan 29, 2021 at 07:02:41PM +0000, Michal Rostecki wrote:
On Fri, Jan 29, 2021 at 06:47:53PM +0100, David Sterba wrote:
quoted
On Fri, Jan 29, 2021 at 05:15:21PM +0000, Michal Rostecki wrote:
quoted
On Fri, Jan 29, 2021 at 11:22:48AM -0500, Josef Bacik wrote:
quoted
On 1/27/21 8:57 AM, Michal Rostecki wrote:
it happens when you run btrfs/060.  Please make sure to run xfstests against
patches before you submit them upstream.  Thanks,

Josef
Umm... I ran the xftests against v1 patch and didn't get that panic.
It could have been caused by my fixups to v2 and I can reproduce the
crash now too. I can't see any difference besides the u64/int switch and
the 'goto out' removal in btrfs_bio_fits_in_stripe.
I was able to fix the issue by the following diff. I will send it as the
patch after confirming that all fstests are passing.
Thanks, can't reproduce the crash with that at least on test btrfs/060.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help