Re: [PATCH v11 01/40] block: add bio_add_zone_append_page

On 22/12/2020 14:35, Christoph Hellwig wrote:

quoted

+int bio_add_zone_append_page(struct bio *bio, struct page *page,
+			     unsigned int len, unsigned int offset)
+{
+	struct request_queue *q;
+	bool same_page = false;
+
+	if (WARN_ON_ONCE(bio_op(bio) != REQ_OP_ZONE_APPEND))
+		return 0;
+
+	q = bio->bi_disk->queue;

I'd still prefer to initialize q at declaration time.

But except for this cosmetic nitpick the patch looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Oops, fixed.