Thread (111 messages) 111 messages, 7 authors, 2020-02-19

Re: [PATCH v6 10/19] fs: Convert mpage_readpages to mpage_readahead

From: Eric Biggers <ebiggers@kernel.org>
Date: 2020-02-19 03:28:33
Also in: linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-xfs, lkml, ocfs2-devel

On Mon, Feb 17, 2020 at 10:45:58AM -0800, Matthew Wilcox wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/mpage.h b/include/linux/mpage.h
index 001f1fcf9836..f4f5e90a6844 100644
--- a/include/linux/mpage.h
+++ b/include/linux/mpage.h
@@ -13,9 +13,9 @@
 #ifdef CONFIG_BLOCK
 
 struct writeback_control;
+struct readahead_control;
 
-int mpage_readpages(struct address_space *mapping, struct list_head *pages,
-				unsigned nr_pages, get_block_t get_block);
+void mpage_readahead(struct readahead_control *, get_block_t get_block);
 int mpage_readpage(struct page *page, get_block_t get_block);
 int mpage_writepages(struct address_space *mapping,
 		struct writeback_control *wbc, get_block_t get_block);
Can you name the 'struct readahead_control *' parameter?

checkpatch.pl should warn about this.

- Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help