Thread (2 messages) 2 messages, 2 authors, 2019-07-24

Re: [PATCH] btrfs-progs: tests: Avoid debug log populating stdout

From: David Sterba <hidden>
Date: 2019-07-24 13:34:36

On Wed, Jul 24, 2019 at 08:00:55PM +0800, Qu Wenruo wrote:
When running misc-test/034, we got unexpected log output:
      [TEST/misc]   033-filename-length-limit
      [TEST/misc]   034-metadata-uuid
  Checking btrfstune logic
  Checking dump-super output
  Checking output after fsid change
  Checking for incompat textual representation
  Checking setting fsid back to original
  Testing btrfs-image restore

This is caused by commit 2570cff076b1 ("btrfs-progs: test: cleanup misc-tests/034")
which uses _log facility which also populates stdout.

Just change _log() to echo "$*" >> "$RESULTS" to fix it.
Unlike the initial commit, there is no other user of _log, so it
shouldn't affect other tests.

Signed-off-by: Qu Wenruo <redacted>
Applied, thanks. I'll fix up the remaining echo > $RESULTS in tests.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help