On 09/25/2018 06:54 PM, Nikolay Borisov wrote:

On 25.09.2018 07:24, Anand Jain wrote:

quoted

Open code helps to grep and find out parameter sent to the
_scratch_mkfs_sized here.

Signed-off-by: Anand Jain <redacted>

IMO this is noise, you can just as simply do
"grep _scratch_mkfs_sized" and then open the file to inspect the actual
argument. But it's up to the xfstest maintainers

  I am ok. Its just a nice cleanup.

Thanks, Anand

quoted

---
  tests/generic/102 | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/generic/102 b/tests/generic/102
index faf940ac5070..aad496a5bc69 100755
--- a/tests/generic/102
+++ b/tests/generic/102

@@ -31,8 +31,7 @@ _require_scratch
  
  rm -f $seqres.full
  
-dev_size=$((512 * 1024 * 1024))     # 512MB filesystem
-_scratch_mkfs_sized $dev_size >>$seqres.full 2>&1
+_scratch_mkfs_sized $((512 * 1024 * 1024)) >>$seqres.full 2>&1
  _scratch_mount
  
  for ((i = 0; i < 10; i++)); do