Re: [PATCH 4/4] locks: map correct ino/dev pairs when exporting to userspace

On Wed, Aug 01, 2018 at 08:37:31AM +0300, Amir Goldstein wrote:

quoted

        if (inode) {
+               __u64 ino;
+               dev_t dev;
+
+               vfs_map_unique_ino_dev(dentry, &ino, &dev);
                /* userspace relies on this representation of dev_t */
                seq_printf(f, "%d %02x:%02x:%ld ", fl_pid,
-                               MAJOR(inode->i_sb->s_dev),
-                               MINOR(inode->i_sb->s_dev), inode->i_ino);
+                               MAJOR(dev), MINOR(dev), inode->i_ino);

Don't you mean ,ino); ?

Indeed I do, thanks for catching that one Amir.
	--Mark