Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.
From: Nikolay Borisov <hidden>
Date: 2018-03-07 12:17:24
From: Nikolay Borisov <hidden>
Date: 2018-03-07 12:17:24
On 7.03.2018 14:14, Qu Wenruo wrote:
<snip>
quoted
quoted
SHARED flag is determined after extent map merge, so here we can't rely on em here.Shouldn't extent maps correspond to 1:1 disk-state. I.e. they are just the memory cache of the extent state. So if we merge them, shouldn't we also merge the on-disk extents as well ?Not 1:1. In memory one is merged maybe to save memory. But on-disk file extents has size limit. For compressed one it's 128K and 128M for uncompressed one.
Fair enough, however 4 extents, 16k each should warrant merging on-disk as well, no ? <snip>