On Thu, Aug 24, 2017 at 11:04:40AM -0700, Liu Bo wrote:

On Thu, Aug 24, 2017 at 07:10:41AM -0700, Christoph Hellwig wrote:

quoted

On Wed, Aug 23, 2017 at 12:15:09PM -0600, Liu Bo wrote:

quoted

flush_epd_write_bio() sets bio->bi_ops by itself to honor REQ_SYNC,
but it's not needed at all since bio->bi_ops has set up properly in
both __extent_writepage() and write_one_eb(), and in the case of
write_one_eb(), it also sets REQ_META, which we will lose in
flush_epd_write_bio().

This remove this unnecessary bio->bi_ops setting.

Nitpick: it's bi_op, not bi_ops.

Ah thanks, it's bio->bi_opf ;)

Heh.  Of course..