Re: [PATCH] btrfs-progs: fix cross-compile build

On 2017年08月25日 01:01, David Sterba wrote:

On Wed, Aug 16, 2017 at 08:17:00AM +0800, Qu Wenruo wrote:

quoted

On 2017年08月16日 02:11, Eric Sandeen wrote:

quoted

The mktables binary needs to be build with the host
compiler at built time, not the target compiler, because
it runs at build time to generate the raid tables.

Copy auto-fu from xfsprogs and modify Makefile to
accomodate this.

Reported-by: Hallo32 <redacted>
Signed-off-by: Eric Sandeen <redacted>

Looks better than my previous patch.
With @BUILD_CLFAGS support and better BUILD_CC/CLFAGS detection for
native build environment.

The contents of tables.c has practially not changed since its
introduction in 2000s. I see no sense in regenerating it each time
during build and I don't want to introduce host CC build just for
this one file, standard practice or not.

I understand the worry about adding host CC.
But just shown by the patch, the impact is minimal.

At least for me and already mentioned before, text file managed by git 
should be reviewable.
No matter if the file get modified in 20 years or not.
(BTW, I don't think there is much problem regenerating the RAID6 table. 
It's way faster than auto-conf/auto-header things)

And I think that's the same reason other projects doesn't manage their 
generated CRC tables using git.

Thanks,
Qu