Thread (4 messages) 4 messages, 3 authors, 2017-09-01

Re: [PATCH] btrfs-progs: print the csum length in debug-tree

From: Nikolay Borisov <hidden>
Date: 2017-08-25 13:48:46


On 25.08.2017 16:13, josef@toxicpanda.com wrote:
quoted hunk ↗ jump to hunk
From: Josef Bacik <redacted>

While looking at a log of a corrupted fs I needed to verify we were
missing csums for a given range.  Make this easier by printing out how
many bytes a csum extent item represents when using btrfs_debug_tree.

Signed-off-by: Josef Bacik <redacted>
---
 print-tree.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/print-tree.c b/print-tree.c
index 5927ed3..a124c96 100644
--- a/print-tree.c
+++ b/print-tree.c
@@ -1103,9 +1103,15 @@ void btrfs_print_leaf(struct btrfs_root *root, struct extent_buffer *eb)
 		case BTRFS_CSUM_ITEM_KEY:
 			printf("\t\tcsum item\n");
 			break;
-		case BTRFS_EXTENT_CSUM_KEY:
-			printf("\t\textent csum item\n");
+		case BTRFS_EXTENT_CSUM_KEY: {
+			u16 csum_size =
+				btrfs_super_csum_size(root->fs_info->super_copy);
+			u32 size = (item_size / csum_size) *
+				root->fs_info->sectorsize;
+			printf("\t\textent csum item bytes %lu\n",
+			       (unsigned long)size);
Currently for a csum item we get:

item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
		extent csum item


 Why don't you go one step further and print the covered range -
it would be key.offset + size (the number you've calculated) And so you
can print something like:

item 0 key (EXTENT_CSUM EXTENT_CSUM 1103101952) itemoff 16279 itemsize 4
		extent csum item 1103101952-1103106048

"extent csum item range %llu-%lly\n", key.offset, key.offset + size

 			break;
+			}
 		case BTRFS_EXTENT_DATA_KEY:
 			print_file_extent_item(eb, item, i, ptr);
 			break;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help