Re: [PATCH] Btrfs: add file item tracepoint

On Tue, Mar 07, 2017 at 04:48:24PM +0100, David Sterba wrote:

On Fri, Mar 03, 2017 at 06:41:27PM -0800, Liu Bo wrote:

quoted

+	TP_printk_btrfs(
+		"root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx "
+		"file extent range [0x%llx 0x%llx] "
+		"(num_bytes 0x%llx ram_bytes 0x%llx disk_bytenr 0x%llx "
+		"disk_num_bytes 0x%llx extent_offset 0x%llx type (%s) "
+		"compression %u",

quoted

+	TP_printk_btrfs(
+		"root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx "
+		"file extent range [0x%llx 0x%llx] "
+		"extent_type (%s) compression %u",

Please update the message formats according to
https://btrfs.wiki.kernel.org/index.php/Development_notes#Tracepoints

I feel like for size and offset, if using '%llu' rather than '%llx', it
is not easy to tell whether the size/offset is aligned to 4K or not.

Thanks,

-liubo