Thread (5 messages) 5 messages, 2 authors, 2016-11-15

Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

From: Tsutomu Itoh <hidden>
Date: 2016-11-02 01:12:22

Sorry for the late reply.

On 2016/10/29 0:10, David Sterba wrote:
On Wed, Oct 19, 2016 at 11:35:03AM +0900, Tsutomu Itoh wrote:
quoted
We cannot send multiple snapshots at once by -p option.
We cannot like that it's broken, or we cannot because it's not supposed
to work that way. I guess it's the former, but the changelog text is a
bit confusing.
Sorry, I'm not good at English.
quoted
[before]
# btrfs send -f /tmp/data0 -p Snap0 Snap[12]
At subvol Snap1
At subvol Snap2
ERROR: parent determination failed for 0
# 

[after]
# btrfs send -f /tmp/data0 -p Snap0 Snap[12]
At subvol Snap1
At subvol Snap2
# 
I'm not sure it's fixed, I wrote a simple test, attached, that triggers
the bug even with the patch applied.
In the attached script,

   run_check $SUDO_HELPER btrfs send -f "$here"/send.stream -p subv-snap1 subv-snap2 subv-snap3

I think that 'btrfs' is a mistake of '$TOP/btrfs'.

Thanks,
Tsutomu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help