Thread (4 messages) 4 messages, 2 authors, 2016-09-30

Re: [PATCH] btrfs-progs: qgroup: Fix regression leads to corrupted qgroup status

From: Qu Wenruo <hidden>
Date: 2016-09-30 00:45:06


At 09/30/2016 01:19 AM, David Sterba wrote:
On Wed, Sep 07, 2016 at 10:54:19AM +0800, Qu Wenruo wrote:
quoted
Commit 93dabf211d74daf6e3de642bdd887a90a00f7b49
Author: Mark Fasheh [off-list ref]
Date:   Fri Jun 17 13:37:48 2016 -0700

    btrfs-progs: check: verify qgroups above level 0

This commit introduced a new regression which corrupts
read_qgroup_status, since it iterate leaf with manually specified slot,
not correct path->slot[0].

This leads to wrong slot[0] and read_qgroup_status() will read out wrong
flags, leading to regression.

Fix read_qgroup_status() by using eb and slot instread of wrong path
strucutre.

Reported-by: Tsutomu Itoh <redacted>
Cc: Mark Fasheh <redacted>
Signed-off-by: Qu Wenruo <redacted>
I'm adding this patch to devel.  Do you have a test for the regression please?
Xfstests btrfs/114 can produce it.

If you mean to add btrfs-progs test case, then I can try to create a 
minimal image to reproduce it.

Thanks,
Qu

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help