Thread (8 messages) 8 messages, 3 authors, 2016-09-01

Re: [PATCH] btrfs: remove pointless debugfs interface

From: David Sterba <hidden>
Date: 2016-08-31 19:10:21

On Wed, Aug 31, 2016 at 10:13:49AM -0500, Eric Sandeen wrote:
A /sys/kernel/debug/btrfs/test file was added nearly
two and a half years ago, but it serves no purpose;
It does. Introduced in 1bae30982bc86ab66d61ccb6e22792593b45d44d says
something about helping developers to easily export information from the
filesystem, to aid debugging. Writing the debugfs support code is not
obviously trivial, so it's idling in the source. Exporing a new value is
as easy as copy and update 3 lines of code. If you have no use for it,
fine.
it stores and returns a value, but nothing in the btrfs
code uses this value in any way.  There are no other btrfs
files in this debugfs dir.

This was brought to my attention because it is world-writable;
it is the only such file under /sys/kernel/debug, and without
knowledge of its purpose, some users were alarmed by this.
So let's fix the permissions.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help