Re: [PATCH 1/3] btrfs-progs: Introduce new send-dump object
From: David Sterba <hidden>
Date: 2016-08-24 12:50:49
On Wed, Aug 17, 2016 at 08:42:48AM +0800, Qu Wenruo wrote:
At 08/16/2016 10:31 PM, David Sterba wrote:quoted
On Mon, Aug 01, 2016 at 02:29:42PM +0800, Qu Wenruo wrote:quoted
Introduce send-dump.[ch] which implements a new btrfs_send_ops to exam and output all operations inside a send stream. It has a better output format than the old and no longer compilable send-test tool, but still tries to be script friendly. Provides the basis for later "inspect-internal dump-send" command.I'd rather put that into the receive subcommand, as it takes the stream as argument and it's closer to the send/receive commands, but that's a minor thing.I'm OK to put it into receive command. Although unlike normal receive usage, it doesn't need the <path> parameter, and make <path> to be optional.
That's a good point and would make the syntax work in two modes, but we do that in ohter commands and I hope it will not be confusing. Exmaples: Normal receive: btrfs receive -f file /mount Dump the stream: btrs receive --dump -f file