Thread (6 messages) 6 messages, 2 authors, 2016-08-29

Re: [PATCH 0/4] Fix chunk num_stripes FPE error found by fuzzed image

From: David Sterba <hidden>
Date: 2016-08-29 16:29:19

On Mon, Aug 29, 2016 at 04:08:58PM +0800, Qu Wenruo wrote:
This patchset will fix chunk num_stripes FPE error, by introducing another 2
layers of check.

1) Check key type validation against leaf owner(for original mode)
   This will prevent invalid key, like CHUNK_ITEM key in root tree, to be
   passed to later check.

   For original mode, it uses leaf's owner as standard.
   For low memory mode, it will use root->objectid(while not in devel
   branch yet)

   This is an extra early check layer, which could benefit other part.

2) Check chunk item again before processing it
   This is the root fix, as final defense for chunk item.
   This check itself can already fix the problem.
   But 1) can give more info on which is really going wrong in the fs.

Thanks for Lukas for his fuzzed images and report.
Thans for the testing and fixes. Can you please also add the images to
tests/fuzz-tests/images ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help