Thread (5 messages) 5 messages, 2 authors, 2016-07-07

Re: [PATCH] Btrfs: fix read_node_slot to return errors

From: David Sterba <hidden>
Date: 2016-07-04 17:07:54

On Tue, Jun 28, 2016 at 06:55:48PM -0700, Liu Bo wrote:
quoted hunk ↗ jump to hunk
@@ -5238,6 +5256,10 @@ static void tree_move_down(struct btrfs_root *root,
 					path->slots[*level]);
 	path->slots[*level - 1] = 0;
 	(*level)--;
+
+	if (IS_ERR(path->nodes[*level - 1]))
+		return PTR_ERR(path->nodes[*level - 1]);
Is this right? *level changes since the call to read_node_slot so I
don't understand which value are we actually testing for error.

Otherwise looks good.
+	return 0;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help