On Mon, Feb 29, 2016 at 10:56 PM, Stanislav Brabec [off-list ref] wrote:

On Feb 26, 2016 at 23:00 Valdis.Kletnieks@vt.edu wrote:

quoted

On Fri, 26 Feb 2016 22:00:44 +0100, Stanislav Brabec said:

quoted

Well, it seems to be safe, even if the loop device was not allocated by
mount(8) itself, as
ioctl(fd, LOOP_CLR_FD)
never returns EBUSY:

The fact you don't get an EBUSY doesn't mean it's actually safe....

Then, what should mount do, when -oloop is used and loop for the file
is already set?

1) Verify that the loop device is a plain loop without encryption, and
recycle it.

2) Allocate new loop device? (Known to cause issues, and corrupts
structures on a current kernel.)

3) Trace loop devices allocated by mount itself and report error, if it
was not allocated by mount. (But there can still be legitimate uses,
e. g. two filesystems in one file, each at different offset, one of
them is encrypted.)

3) Report error and recommend direct use of /dev/loop*. (See 3 plus
setup of a system with /dev/loop* in fstab needs a non-standard
actions.)

4) Other ideas?

One idea is to just take the loop which has been set for the file, and
it should work well no matter if the orignal loop is mounted or not.

Thanks,

--
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                         e-mail: sbrabec@suse.com
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                 fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76

-- 
Ming Lei