Thread (4 messages) 4 messages, 3 authors, 2016-02-23

Re: [PATCH] btrfs: use proper type for failrec in extent_state

From: David Sterba <hidden>
Date: 2016-02-23 11:34:17

On Tue, Feb 23, 2016 at 10:06:59AM +0800, Qu Wenruo wrote:
quoted
I'm not sure why, but my gcc 5.3.1 think's that a member of failrec can
be used uninitialized:

   CC [M]  fs/btrfs/extent_io.o
fs/btrfs/extent_io.c: In function ‘clean_io_failure’:
fs/btrfs/extent_io.c:2133:4: warning: ‘failrec’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     repair_io_failure(inode, start, failrec->len,
     ^
After applying your patch on integration-4.6, and compiling, my gcc 
5.3.0 didn't give such warning though.

And I didn't see an official 5.3.1, but only 5.3 so I assume maybe it's 
related to the .1 from your distribution?
Yes it's distro gcc 5.3 + patches. Arnd sent a patch to fix the warning.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help