Thread (10 messages) 10 messages, 4 authors, 2014-09-02

Re: [PATCH] Btrfs: fix crash on endio of reading corrupted block

From: Chris Mason <clm@fb.com>
Date: 2014-08-19 19:49:28


On 08/19/2014 11:33 AM, Liu Bo wrote:
The crash is

------------[ cut here ]------------
kernel BUG at fs/btrfs/extent_io.c:2124!
[...]
Workqueue: btrfs-endio normal_work_helper [btrfs]
RIP: 0010:[<ffffffffa02d6055>]  [<ffffffffa02d6055>] end_bio_extent_readpage+0xb45/0xcd0 [btrfs]

This is in fact a regression.

It is because we forgot to increase @offset properly in reading corrupted block,
so that the @offset remains, and this leads to checksum errors while reading
left blocks queued up in the same bio, and then ends up with hiting the above
BUG_ON.
Thanks Chris and Liu, this is queued.

-chris
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help