Thread (8 messages) 8 messages, 3 authors, 2012-11-20
STALE4964d

[PATCH 3/4][RFC] btrfs: remove duplicated check from btrfs_fallocate

From: Zheng Liu <hidden>
Date: 2012-11-20 09:17:22
Also in: linux-ext4, linux-fsdevel, linux-xfs
Subsystem: btrfs file system, filesystems (vfs and infrastructure), the rest · Maintainers: Chris Mason, David Sterba, Alexander Viro, Christian Brauner, Linus Torvalds

From: Zheng Liu <redacted>

Remove a sanity check from btrfs_fallocate because vfs has already checked it.

Reported-by: Guo Chao <redacted>
Signed-off-by: Zheng Liu <redacted>
---
 fs/btrfs/file.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 9ab1bed..fd260a0 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -1999,10 +1999,6 @@ static long btrfs_fallocate(struct file *file, int mode,
 	alloc_start = offset & ~mask;
 	alloc_end =  (offset + len + mask) & ~mask;
 
-	/* Make sure we aren't being give some crap mode */
-	if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))
-		return -EOPNOTSUPP;
-
 	if (mode & FALLOC_FL_PUNCH_HOLE)
 		return btrfs_punch_hole(inode, offset, len);
 
-- 
1.7.12.rc2.18.g61b472e
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help