Re: [PATCH V2] Btrfs-progs: add parent uuid for snapshots

I agree. Thanks for the comments.
New patch has been sent out.

-Anand


On 09/10/12 23:44, David Sterba wrote:

On Fri, Oct 05, 2012 at 10:25:22AM +0800, Anand jain wrote:

quoted

@@ -128,6 +129,11 @@ struct {
  		.need_print	= 0,
  	},
  	{
+		.name		= "puuid",
+		.column_name	= "PUUID",

the capitalized 'P' looks like it's part of the UUID abbreviation. The
UUIDs are long, I think you can print 'parent UUID' in the header, the
name for command line argument 'puuid' is understable.

quoted

+		.need_print	= 0,
+	},
+	{
  		.name		= "uuid",
  		.column_name	= "UUID",
  		.need_print	= 0,

quoted

--- a/cmds-subvolume.c
+++ b/cmds-subvolume.c

@@ -267,6 +267,7 @@ static const char * const cmd_subvol_list_usage[] = {
  	"-p           print parent ID",
  	"-a           print all the subvolumes in the filesystem.",
  	"-u           print the uuid of subvolumes (and snapshots)",
+	"-P           print the parent uuid of snapshots",

This clashes with my efforts to make the options consistent so that we
can have a lowercase for column selection and uppercase for filter. In
case of the parent UUID,  it makes sense to filter by it, eg when we
have a hierarchy of subvolumes that keep the same structure but is
replicated several times.

I suggest to pick a different letter than 'P', say 'q'. (-q is usually
used for 'no verbose output' in utilities, but it does not make much
sense in context of 'subvol list' so I hope it's ok from the UI POV).

quoted

  	"-t           print the result as a table",
  	"-s           list snapshots only in the filesystem",
  	"-r           list readonly subvolumes (including snapshots)",

Thanks,
david