Thread (12 messages) 12 messages, 2 authors, 2012-09-18

Re: [PATCH V3 4/7] Btrfs-progs: fix wrong way to check if the root item contains otime and uuid

From: Miao Xie <hidden>
Date: 2012-09-18 06:11:40

On Tue, 18 Sep 2012 13:56:44 +0800, Anand Jain wrote:
quoted
-                if(ri->generation == ri->generation_v2) {
+                if(sh->len == sizeof(struct btrfs_root_item)) {
                      t = ri->otime.sec;
 This looks fine now but should this work when we
 move to v3 and still have access to v2 introduced
 members.?

 ker cli
 v3  v2  v2 introduced members are unnecessarily blocked
 v2  v3  --as above--
No.

I will update my patch to fix this problem.

Thanks
Miao
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help