Re: [PATCH] Btrfs: fix off-by-one in file clone
From: David Sterba <hidden>
Date: 2012-09-19 16:50:25
From: David Sterba <hidden>
Date: 2012-09-19 16:50:25
On Tue, Sep 18, 2012 at 05:52:23PM +0800, Liu Bo wrote:
Btrfs uses inclusive range end for lock_extent(), unlock_extent() and related functions, so we made off-by-one errors in file clone.
We're lucky that it's off-by-one in a way that it locks more than it should. The function is full of such calculations, I didn't spot any other instances, but another review round would not harm. Reviewed-by: David Sterba <redacted>