On 09/25/2012 06:51 PM, David Sterba wrote:

On Mon, Sep 24, 2012 at 11:03:49PM +0200, David Sterba wrote:

quoted

Could you please put the check into a separate helper

Please note that checksum will become a variable per-filesystem
property, stored within the superblock, so the helper should be passed a
fs_info pointer.

thanks,
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

How about enhancing the "thread_pool=number" mount option instead?

thread_pool=n                     enable threadpool for compression and checksum, MAY improve bandwidth
thread_pool=0                     disable threadpool for compression and checksum, MIGHT reduce latency
thread_pool=-1 or not provided    automatically managed (current behavior and default choice)


This should allow user to tradeoff between latency and bandwidth, furthermore, you do not need to assume that btrfs may use crc32c algorithm only forever.