On Mon, Sep 17, 2012 at 06:23:21PM -0600, Liu Bo wrote:

On 09/18/2012 01:15 AM, Josef Bacik wrote:

quoted

On Mon, Sep 17, 2012 at 03:58:56AM -0600, Liu Bo wrote:

quoted

This comes from one of btrfs's project ideas,
As we defragment files, we break any sharing from other snapshots.
The balancing code will preserve the sharing, and defrag needs to grow this
as well.

Now we're able to fill the blank with this patch, in which we make full use of
backref walking stuff.

Here is the basic idea,
o  set the writeback ranges started by defragment with flag EXTENT_DEFRAG
o  at endio, after we finish updating fs tree, we use backref walking to find
   all parents of the ranges and re-link them with the new COWed file layout by
   adding corresponding backrefs.

Originally patch by Li Zefan [off-list ref]
Signed-off-by: Liu Bo <redacted>

I was trying to fixup the rejects on this patch when I noticed there were no
tabs, only spaces.  Thats not going to work and now I have to go back and make
sure none of your other patches did this.  Thanks,

Josef

I'm quite confused about this, my local part and the email part I received show it is well formed.

There is no spaces, and every time before I send them out, I use checkpatch.pl and make sure
checkpatch.pl does not complain about anything:

$ ./scripts/checkpatch.pl ~/Desktop/0002-Btrfs-snapshot-aware-defrag.patch 
total: 0 errors, 0 warnings, 647 lines checked

/home/liubo/Desktop/0002-Btrfs-snapshot-aware-defrag.patch has no obvious style problems and is ready for submission.


Anyway, I don't know where goes wrong but I'm attaching it for you.

Yeah I don't know wtf is going on here, that patch turned out fine.  I blame
exchange ;).  Thanks,

Josef