On 06/29/2012 06:21 PM, Ilya Dryomov wrote:

On Fri, Jun 29, 2012 at 06:00:36PM +0800, Liu Bo wrote:

quoted

Setting subvolume/snapshot readonly has been missing for a long time.

With this patch, we can set a subvolume/snapshot readonly via:

o    btrfs subvolume set-ro <path>

Alexander's 'btrfs property' patches do exactly this, but in a much more
generic and extensible way.  'btrfs property' subgroup provides a
uniform interface for getting and setting properties of filesystem
objects in general, not only those of subvolumes and snapshots.  It
provides a much better user interface, and it also allows us to easily
rethink kernel-user interface for generic get/set in future.

Thanks for the explanation!

But I prefer keeping the current categories {subvolume,filesystem,device,...}:

o Compatibility, we cannot remove the old commands until we make sure that no users will
  use them.

o We've three properties {default, readonly, lable}, is it worthy making another new interface?

o Current categories are clear and clean.


thanks,
liubo

Thanks,

		Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html