Thread (43 messages) 43 messages, 6 authors, 2012-08-01

Re: [RFC PATCH 5/7] Btrfs: add btrfs_compare_trees function

From: David Sterba <hidden>
Date: 2012-07-04 23:31:07

On Wed, Jul 04, 2012 at 10:18:34PM +0200, Alexander Block wrote:
quoted
It might be worth to note in the comment, that tmp_buff should be
large enough to hold the item from the left tree. Can it happen that
the right tree has a different leafsize?
This function is only to be used for for the tree compare function and
there we allocate a buffer of root->leafsize, so definitely all items
should fit. As far as I know, Chris (please correct me if I'm wrong)
once guaranteed that ALL trees in a FS will have the same leaf size
and this will ever be the case.
Not only leaves are of the same size in all trees, but also nodes, since
the metadata bigblocks patches.

david
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help