Thread (13 messages) 13 messages, 4 authors, 2012-07-07

Re: [PATCH 1/4] Btrfs: use radix tree for checksum

From: Zach Brown <hidden>
Date: 2012-06-13 16:07:38

  int set_state_private(struct extent_io_tree *tree, u64 start, u64 private)
  {
[...]
+	ret = radix_tree_insert(&tree->csum, (unsigned long)start,
+			       (void *)((unsigned long)private<<  1));
Will this fail for 64bit files on 32bit hosts?
+	BUG_ON(ret);
I wonder if we can patch BUG_ON() to break the build if its only
argument is "ret".

- z
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help