On Wed, Feb 15, 2012 at 01:43:02PM +0800, Anand Jain wrote:

Hi Xin / Hugo,
 I am referring to
 git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git

 has miss match parameter list for list_subvols
 ----------
 # cd btrfs-progs
 # egrep list_subvols *
 btrfs_cmds.c:	ret = list_subvols(fd, print_parent, 0);
 btrfs_cmds.c:	ret = list_subvols(fd, 0, 1);
 btrfs_cmds.h:int list_subvols(int fd, int print_parent, int get_default);  <-----
 btrfs-list.c:int list_subvols(int fd, int print_parent)  <-----
 ----------

 ----------
 # egrep -A 3 list_subvols btrfs-list.c
 int list_subvols(int fd, int print_parent)
 {
	struct root_lookup root_lookup;
	struct rb_node *n;
 ----------
 Looks like the following patch was checked in partially.
   http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg11103.html

 Could you pls take a look / comment.

I looked at this issue briefly when testing the new parser.  Looks like
Jan broke it with his split of list_subvols.  Jan's code was probably
based on the master branch of the old progs repo, whereas get-default
was based on one of the integration branches and the subsequent merge
missed it.  I'll fix it if nobody else steps up.

Thanks,

		Ilya