Re: [PATCH] Btrfs: release space on error in page_mkwrite

On Tue, Jan 10, 2012 at 02:20:18PM -0500, Josef Bacik wrote:

If updating the inode gave us an ENOSPC we were just returning in page_mkwrite,
which is a problem since we make our reservation right before trying to update
the inode, so fix the out label so that we actually free our reservation.
Thanks,

Signed-off-by: Josef Bacik <redacted>

Tested-by: David Sterba <redacted>

reproducer:

while :;do ./check 209;done

and some writeback activity, i used compilation or multithreaed random
writes via fio. the warning

WARNING: at fs/btrfs/extent-tree.c:7283 btrfs_free_block_groups+0x25b/0x370

appeared within minutes.


david