[PATCH 8/11] fs/btrfs/volumes.c: trivial: use BUG_ON
From: Julia Lawall <hidden>
Date: 2011-08-02 10:36:43
Also in:
kernel-janitors, lkml
Subsystem:
btrfs file system, filesystems (vfs and infrastructure), the rest · Maintainers:
Chris Mason, David Sterba, Alexander Viro, Christian Brauner, Linus Torvalds
From: Julia Lawall <redacted> Use BUG_ON(x) rather than if(x) BUG(); The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl>
@@ identifier x; @@ -if (x) BUG(); +BUG_ON(x);
@@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x);
// </smpl> Signed-off-by: Julia Lawall <redacted> --- fs/btrfs/volumes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 19450bc..275be0f 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c@@ -1983,8 +1983,8 @@ again: found_key.offset); if (ret == -ENOSPC) failed++; - else if (ret) - BUG(); + else + BUG_ON(ret); } if (found_key.offset == 0)