Re: [PATCH] [btrfs-progs integration] incorrect argument checking for "btrfs sub snap -r"
From: Hugo Mills <hidden>
Date: 2011-06-30 13:07:39
On Thu, Jun 30, 2011 at 01:34:38PM +0100, Stephane Chazelas wrote:
quoted hunk ↗ jump to hunk
Looks like this was missing in integration-20110626 for the readonly snapshot patch:diff --git a/btrfs.c b/btrfs.c index e117172..be6ece5 100644 --- a/btrfs.c +++ b/btrfs.c@@ -49,7 +49,7 @@ static struct Command commands[] = { /* avoid short commands different for the case only */ - { do_clone, 2, + { do_clone, -1, "subvolume snapshot", "[-r] <source> [<dest>/]<name>\n" "Create a writable/readonly snapshot of the subvolume <source> with\n" "the name <name> in the <dest> directory.",Without that, "btrfs sub snap -r x y" would fail as it's not *2* arguments.
Thanks. Added to the queue. Hugo. -- === Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk === PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk --- "How deep will this sub go?" "Oh, she'll go all the way to --- the bottom if we don't stop her."
Attachments
- signature.asc [application/pgp-signature] 190 bytes