Re: [PATCH v2] btrfs: Remove all sysfs entries

On Wed, Jun 15, 2011 at 10:54:13AM -0500, Mitch Harder wrote:

On Wed, Jun 15, 2011 at 5:34 AM, Hugo Mills [off-list ref] wrote:

quoted

On Wed, Jun 15, 2011 at 10:40:31AM +0200, Maarten Lankhorst wrote:

quoted

Seems that currently none of the sysfs are created any more, so just
remove sysfs support entirely.

Fixes compiling warnings in 3.0rc3

  I would actually like to retain sysfs support -- the current
entries may not be used (or useful, or in the right place, or even
visible these days), but there's plenty of things that could and
should go in sysfs from btrfs.

  So, please do remove the unwanted/unused file entries, but could
you leave the sysfs file itself, and the (limited) bits that create
the btrfs subdir? Otherwise, I'm going to be putting it all back in
this weekend when I get the time to revisit Goffredo's old sysfs
patch...

I'm not sure if Goffredo is following this thread, but I think you'll
need a missing patch to provide a fs/btrfs/sysfs.h file in order to
use his sysfs patch.

   OK, thanks for the warning. I'm not expecting Goffredo's patch to
be a complete drop-in turn-key solution -- he did warn that it was
only a first draft when he originally posted it.

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
    --- Anyone using a computer to generate random numbers is, of ---    
                       course,  in a state of sin.