[bluez/bluez] 44b461: audio: Don't initialize media transport volume fro...

From: Myrrh Periwinkle <hidden>
Date: 2025-08-06 01:17:09

  Branch: refs/heads/988586
  Home:   https://github.com/bluez/bluez
  Commit: 44b461d8b2c66711bf0bc6e88dda6cd37b406bbd
      https://github.com/bluez/bluez/commit/44b461d8b2c66711bf0bc6e88dda6cd37b406bbd
  Author: Myrrh Periwinkle [off-list ref]
  Date:   2025-08-06 (Wed, 06 Aug 2025)

  Changed paths:
    M profiles/audio/avrcp.c
    M profiles/audio/media.c
    M profiles/audio/media.h

  Log Message:
  -----------
  audio: Don't initialize media transport volume from media player

Media player objects may be shared between devices. As a result,
a device without support for hardware volume that is connected after one
that does may end up being erroneously considered hardware
volume-capable.

fa7828bdd ("transport: Fix not being able to initialize volume properly")
introduced btd_device_{get,set}_volume that is used as an alternative in
case no media player objects are present. Therefore, we can remove
media_player_get_device_volume and instead use btd_device_get_volume to
determine the initial volume.


  Commit: e8d54fe4e24bae02c1ed0f465eeefec1f672498b
      https://github.com/bluez/bluez/commit/e8d54fe4e24bae02c1ed0f465eeefec1f672498b
  Author: Myrrh Periwinkle [off-list ref]
  Date:   2025-08-06 (Wed, 06 Aug 2025)

  Changed paths:
    M profiles/audio/avrcp.c
    M profiles/audio/avrcp.h
    M profiles/audio/media.c

  Log Message:
  -----------
  audio: Remove media_player.volume

With the previous commit, the media_player.volume field is now
completely unused. As this was never the right place to store the
initial volume to begin with, remove this field entirely as well as its
associated supporting methods to prevent confusion.


Compare: https://github.com/bluez/bluez/compare/44b461d8b2c6%5E...e8d54fe4e24b

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help