[PATCH 1/2] Bluetooth: Fix handling of experimental feature for quality reports

The existence of the experimental feature identifiy is the indication
that it is supported or not. No extra flag needed and the initial flag
should define if a feature is enabled or not. This is actually defined
in the management API definition.

Fixes: ae7d925b5c043 ("Bluetooth: Support the quality report events")
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
 net/bluetooth/mgmt.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index a6aeefd2c14f..84336be4d00d 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c

@@ -3863,19 +3863,12 @@ static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev,
 		idx++;
 	}
 
-	if (hdev) {
-		if (hdev->set_quality_report) {
-			/* BIT(0): indicating if set_quality_report is
-			 * supported by controller.
-			 */
+	if (hdev && hdev->set_quality_report) {
+		if (hci_dev_test_flag(hdev, HCI_QUALITY_REPORT))
 			flags = BIT(0);
-
-			/* BIT(1): indicating if the feature is enabled. */
-			if (hci_dev_test_flag(hdev, HCI_QUALITY_REPORT))
-				flags |= BIT(1);
-		} else {
+		else
 			flags = 0;
-		}
+
 		memcpy(rp->features[idx].uuid, quality_report_uuid, 16);
 		rp->features[idx].flags = cpu_to_le32(flags);
 		idx++;

-- 
2.31.1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=554141

---Test result---

Test Summary:
CheckPatch                    PASS      2.98 seconds
GitLint                       PASS      1.76 seconds
BuildKernel                   PASS      565.64 seconds
TestRunner: Setup             PASS      418.20 seconds
TestRunner: l2cap-tester      PASS      9.41 seconds
TestRunner: bnep-tester       PASS      5.05 seconds
TestRunner: mgmt-tester       FAIL      81.04 seconds
TestRunner: rfcomm-tester     PASS      6.25 seconds
TestRunner: sco-tester        PASS      6.48 seconds
TestRunner: smp-tester        PASS      6.54 seconds
TestRunner: userchan-tester   PASS      5.32 seconds

Details
##############################
Test: TestRunner: mgmt-tester - FAIL - 81.04 seconds
Run test-runner with mgmt-tester
Total: 452, Passed: 451 (99.8%), Failed: 1, Not Run: 0

Failed Test Cases
Read Exp Feature - Success                           Failed       0.103 seconds



---
Regards,
Linux Bluetooth

Hi Marcel,

On Tue, Sep 28, 2021 at 9:09 AM [off-list ref] wrote:

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=554141

---Test result---

Test Summary:
CheckPatch                    PASS      2.98 seconds
GitLint                       PASS      1.76 seconds
BuildKernel                   PASS      565.64 seconds
TestRunner: Setup             PASS      418.20 seconds
TestRunner: l2cap-tester      PASS      9.41 seconds
TestRunner: bnep-tester       PASS      5.05 seconds
TestRunner: mgmt-tester       FAIL      81.04 seconds
TestRunner: rfcomm-tester     PASS      6.25 seconds
TestRunner: sco-tester        PASS      6.48 seconds
TestRunner: smp-tester        PASS      6.54 seconds
TestRunner: userchan-tester   PASS      5.32 seconds

Details
##############################
Test: TestRunner: mgmt-tester - FAIL - 81.04 seconds
Run test-runner with mgmt-tester
Total: 452, Passed: 451 (99.8%), Failed: 1, Not Run: 0

Failed Test Cases
Read Exp Feature - Success                           Failed       0.103 seconds



---
Regards,
Linux Bluetooth

Applied, thanks.

-- 
Luiz Augusto von Dentz