[RFC BlueZ] mgmt-api: Introduce Test command

Subsystems: the rest

3 messages, 3 authors, 2021-09-10 · open the first message on its own page

[RFC BlueZ] mgmt-api: Introduce Test command

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2021-09-09 21:47:56

From: Luiz Augusto von Dentz <redacted>

This introduces Test command which can be use to further extend the
subcommands which are intented to test the behavior of the kernel
outside the normal scope of Bluetooth subsystem (e.g. suspend, resume,
etc).
---
 doc/mgmt-api.txt | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index 5355fedb0..164a0514d 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -3856,6 +3856,33 @@ Add Advertisement Patterns Monitor With RSSI Threshold Command
 				No Resources
 				Invalid Parameters
 
+Test Command
+============
+	Command Code:		0xffff
+	Controller Index:	<controller id>
+	Command Parameters:	Subcommand code (1 Octet)
+				Subcommand length (2 Octects)
+	Return Parameters:      subcommand return (variable)
+
+	This command is meant for testing only, it shall not be used in
+	production.
+
+	Possible subcommands:
+
+	Suspend
+	-------
+	Subcommand Code:	0x0001
+	Subcommand Parameters:
+	Subcommand Return Parameters:
+
+	Resume
+	-------
+	Subcommand Code:	0x0002
+	Subcommand Parameters:
+	Subcommand Return Parameters:
+
+	Possible errors:	Failed
+				Subcommand errors
 
 Command Complete Event
 ======================
-- 
2.31.1

RE: [RFC,BlueZ] mgmt-api: Introduce Test command

From: <hidden>
Date: 2021-09-09 22:35:47

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=544637

---Test result---

Test Summary:
CheckPatch                    FAIL      0.27 seconds
GitLint                       PASS      0.13 seconds
Prep - Setup ELL              PASS      45.43 seconds
Build - Prep                  PASS      0.10 seconds
Build - Configure             PASS      8.02 seconds
Build - Make                  PASS      194.81 seconds
Make Check                    PASS      8.94 seconds
Make Distcheck                PASS      233.16 seconds
Build w/ext ELL - Configure   PASS      8.10 seconds
Build w/ext ELL - Make        PASS      185.24 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
mgmt-api: Introduce Test command
WARNING:TYPO_SPELLING: 'intented' may be misspelled - perhaps 'intended'?
#7: 
subcommands which are intented to test the behavior of the kernel
                      ^^^^^^^^

- total: 0 errors, 1 warnings, 33 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] mgmt-api: Introduce Test command" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth

Re: [RFC BlueZ] mgmt-api: Introduce Test command

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-09-10 07:25:45

Hi Luiz,
quoted hunk
This introduces Test command which can be use to further extend the
subcommands which are intented to test the behavior of the kernel
outside the normal scope of Bluetooth subsystem (e.g. suspend, resume,
etc).
---
doc/mgmt-api.txt | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index 5355fedb0..164a0514d 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -3856,6 +3856,33 @@ Add Advertisement Patterns Monitor With RSSI Threshold Command
				No Resources
				Invalid Parameters

+Test Command
+============
+	Command Code:		0xffff
+	Controller Index:	<controller id>
+	Command Parameters:	Subcommand code (1 Octet)
+				Subcommand length (2 Octects)
+	Return Parameters:      subcommand return (variable)
+
+	This command is meant for testing only, it shall not be used in
+	production.
+
+	Possible subcommands:
+
+	Suspend
+	-------
+	Subcommand Code:	0x0001
+	Subcommand Parameters:
+	Subcommand Return Parameters:
I rather do this via debugfs.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help