[PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo

Subsystems: the rest

STALE2239d

3 messages, 2 authors, 2020-07-28 · open the first message on its own page

[PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo

From: Sonny Sasaka <hidden>
Date: 2020-07-17 23:14:15

Chromium OS developers use gerrit and repo in their workflow.
(https://gerrit.googlesource.com/git-repo/). This configuration file
makes it easier when uploading patches to gerrit with the repo tool.

---
 PRESUBMIT.cfg | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 PRESUBMIT.cfg
diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
new file mode 100644
index 000000000..10f89b741
--- /dev/null
+++ b/PRESUBMIT.cfg
@@ -0,0 +1,8 @@
+# This is a configuration for Chromium OS repo pre-upload hooks.
+# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/
+# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/
+
+[Hook Overrides]
+cros_license_check: false
+tab_check: false
+checkpatch_check: true
-- 
2.26.2

Re: [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo

From: Sonny Sasaka <hidden>
Date: 2020-07-22 20:35:07

Maintainers, could you take a look at this? We started using a mirror
of upstream in chromium repo, so we can not apply this PRESUBMIT.cfg
file as our own commit. It'd be great if this file can be submitted
upstream as well to help Chromium OS developers' workflow.

On Fri, Jul 17, 2020 at 4:14 PM Sonny Sasaka [off-list ref] wrote:
quoted hunk
Chromium OS developers use gerrit and repo in their workflow.
(https://gerrit.googlesource.com/git-repo/). This configuration file
makes it easier when uploading patches to gerrit with the repo tool.

---
 PRESUBMIT.cfg | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 PRESUBMIT.cfg
diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
new file mode 100644
index 000000000..10f89b741
--- /dev/null
+++ b/PRESUBMIT.cfg
@@ -0,0 +1,8 @@
+# This is a configuration for Chromium OS repo pre-upload hooks.
+# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/
+# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/
+
+[Hook Overrides]
+cros_license_check: false
+tab_check: false
+checkpatch_check: true
--
2.26.2

Re: [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2020-07-28 07:14:11

Hi Sonny,
quoted hunk
Chromium OS developers use gerrit and repo in their workflow.
(https://gerrit.googlesource.com/git-repo/). This configuration file
makes it easier when uploading patches to gerrit with the repo tool.

---
PRESUBMIT.cfg | 8 ++++++++
1 file changed, 8 insertions(+)
create mode 100644 PRESUBMIT.cfg
diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
new file mode 100644
index 000000000..10f89b741
--- /dev/null
+++ b/PRESUBMIT.cfg
@@ -0,0 +1,8 @@
+# This is a configuration for Chromium OS repo pre-upload hooks.
+# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/
+# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/
+
+[Hook Overrides]
+cros_license_check: false
+tab_check: false
+checkpatch_check: true
I am not in favor of adding anything in the top-level directory that is not for for the BlueZ upstream usage.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help