[PATCH] android/gatt: Fix wrong size argument

Subsystems: the rest

STALE4435d

2 messages, 2 authors, 2014-06-25 · open the first message on its own page

[PATCH] android/gatt: Fix wrong size argument

From: Andrei Emeltchenko <hidden>
Date: 2014-06-19 10:36:19

From: Andrei Emeltchenko <redacted>

Instead of sizeof of (uint8_t *) pass real length, though for that
function it doesn't matter at this point.
---
 android/gatt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/gatt.c b/android/gatt.c
index 5007817..7ce57ca 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -5688,7 +5688,7 @@ static void att_handler(const uint8_t *ipdu, uint16_t len, gpointer user_data)
 		 * registered for this indication, event will be send in
 		 * handle_notification
 		 */
-		resp_length = enc_confirmation(opdu, sizeof(opdu));
+		resp_length = enc_confirmation(opdu, length);
 		status = 0;
 		break;
 	case ATT_OP_HANDLE_NOTIFY:
-- 
1.8.3.2

Re: [PATCH] android/gatt: Fix wrong size argument

From: Szymon Janc <hidden>
Date: 2014-06-25 15:18:13

Hi Andrei,

On Thursday 19 of June 2014 13:36:19 Andrei Emeltchenko wrote:
quoted hunk
From: Andrei Emeltchenko <redacted>

Instead of sizeof of (uint8_t *) pass real length, though for that
function it doesn't matter at this point.
---
 android/gatt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/gatt.c b/android/gatt.c
index 5007817..7ce57ca 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -5688,7 +5688,7 @@ static void att_handler(const uint8_t *ipdu, uint16_t len, gpointer user_data)
 		 * registered for this indication, event will be send in
 		 * handle_notification
 		 */
-		resp_length = enc_confirmation(opdu, sizeof(opdu));
+		resp_length = enc_confirmation(opdu, length);
 		status = 0;
 		break;
 	case ATT_OP_HANDLE_NOTIFY:
Applied. Thanks.

-- 
Best regards, 
Szymon Janc
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help