[PATCH obexd v1 2/3] MAP: Add set read status function

Subsystems: the rest

STALE5132d

2 messages, 2 authors, 2012-09-14 · open the first message on its own page

[PATCH obexd v1 2/3] MAP: Add set read status function

From: Sunil Kumar Behera <hidden>
Date: 2012-09-13 13:43:28

This function will inform MAP server to modify the
read status of a given message.
---
 plugins/mas.c              |   25 +++++++++++++++++++++++++
 plugins/messages-dummy.c   |    6 ++++++
 plugins/messages-tracker.c |    6 ++++++
 plugins/messages.h         |   13 +++++++++++++
 4 files changed, 50 insertions(+)
diff --git a/plugins/mas.c b/plugins/mas.c
index f2ff9e6..14e7478 100644
--- a/plugins/mas.c
+++ b/plugins/mas.c
@@ -46,6 +46,8 @@
 
 #include "messages.h"
 
+#define READ_STATUS_REQ 0
+
 /* Channel number according to bluez doc/assigned-numbers.txt */
 #define MAS_CHANNEL	16
 
@@ -499,6 +501,20 @@ static void update_inbox_cb(void *session, int err, void *user_data)
 		obex_object_set_io_flags(mas, G_IO_OUT, 0);
 }
 
+static void set_read_status_cb(void *session, int err, void *user_data)
+{
+	struct mas_session *mas = user_data;
+
+	DBG("");
+
+	mas->finished = TRUE;
+
+	if (err < 0)
+		obex_object_set_io_flags(mas, G_IO_ERR, err);
+	else
+		obex_object_set_io_flags(mas, G_IO_OUT, 0);
+}
+
 static int mas_setpath(struct obex_session *os, void *user_data)
 {
 	const char *name;
@@ -677,6 +693,15 @@ static void *message_set_status_open(const char *name, int oflag, mode_t mode,
 		return NULL;
 	}
 
+	if (indicator == READ_STATUS_REQ)
+		*err = messages_set_read(mas->backend_data, name, value,
+						set_read_status_cb, mas);
+	else
+		*err = -EBADR;
+
+	if (*err < 0)
+		return NULL;
+
 	return mas;
 }
 
diff --git a/plugins/messages-dummy.c b/plugins/messages-dummy.c
index a47f143..78e20ae 100644
--- a/plugins/messages-dummy.c
+++ b/plugins/messages-dummy.c
@@ -353,6 +353,12 @@ int messages_update_inbox(void *session, messages_update_inbox_cb callback,
 	return -ENOSYS;
 }
 
+int messages_set_read(void *session, const char *handle, uint8_t value,
+				messages_set_read_cb callback, void *user_data)
+{
+	return -ENOSYS;
+}
+
 void messages_abort(void *s)
 {
 	struct session *session = s;
diff --git a/plugins/messages-tracker.c b/plugins/messages-tracker.c
index 92c1767..1516dc7 100644
--- a/plugins/messages-tracker.c
+++ b/plugins/messages-tracker.c
@@ -327,6 +327,12 @@ int messages_update_inbox(void *session, messages_update_inbox_cb callback,
 	return -ENOSYS;
 }
 
+int messages_set_read(void *session, const char *handle, uint8_t value,
+				messages_set_read_cb callback, void *user_data)
+{
+	return -ENOSYS;
+}
+
 void messages_abort(void *session)
 {
 }
diff --git a/plugins/messages.h b/plugins/messages.h
index 669f7c2..45579d3 100644
--- a/plugins/messages.h
+++ b/plugins/messages.h
@@ -279,6 +279,19 @@ typedef void (*messages_update_inbox_cb)(void *session, int err,
 
 int messages_update_inbox(void *session, messages_update_inbox_cb callback,
 							void *user_data);
+/* Informs Message Server to modify read status of a given message.
+ *
+ * session: Backend session.
+ * handle: Unique identifier to the message.
+ * value: Indicates the new value of the read status for a given message.
+ * Callback shall be called for every read status update request
+ *	recieved from MCE.
+ * user_data: User data if any to be sent.
+ */
+typedef void (*messages_set_read_cb)(void *session, int err, void *user_data);
+
+int messages_set_read(void *session, const char *handle, uint8_t value,
+				messages_set_read_cb callback, void *user_data);
 
 /* Aborts currently pending request.
  *
-- 
1.7.9.5

Re: [PATCH obexd v1 2/3] MAP: Add set read status function

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-09-14 10:25:07

Hi Sunil,

On Thu, Sep 13, 2012 at 4:43 PM, Sunil Kumar Behera
[off-list ref] wrote:
quoted hunk
This function will inform MAP server to modify the
read status of a given message.
---
 plugins/mas.c              |   25 +++++++++++++++++++++++++
 plugins/messages-dummy.c   |    6 ++++++
 plugins/messages-tracker.c |    6 ++++++
 plugins/messages.h         |   13 +++++++++++++
 4 files changed, 50 insertions(+)
diff --git a/plugins/mas.c b/plugins/mas.c
index f2ff9e6..14e7478 100644
--- a/plugins/mas.c
+++ b/plugins/mas.c
@@ -46,6 +46,8 @@

 #include "messages.h"

+#define READ_STATUS_REQ 0
+
 /* Channel number according to bluez doc/assigned-numbers.txt */
 #define MAS_CHANNEL    16
@@ -499,6 +501,20 @@ static void update_inbox_cb(void *session, int err, void *user_data)
                obex_object_set_io_flags(mas, G_IO_OUT, 0);
 }

+static void set_read_status_cb(void *session, int err, void *user_data)
+{
+       struct mas_session *mas = user_data;
+
+       DBG("");
+
+       mas->finished = TRUE;
+
+       if (err < 0)
+               obex_object_set_io_flags(mas, G_IO_ERR, err);
+       else
+               obex_object_set_io_flags(mas, G_IO_OUT, 0);
+}
+
 static int mas_setpath(struct obex_session *os, void *user_data)
 {
        const char *name;
@@ -677,6 +693,15 @@ static void *message_set_status_open(const char *name, int oflag, mode_t mode,
                return NULL;
        }

+       if (indicator == READ_STATUS_REQ)
+               *err = messages_set_read(mas->backend_data, name, value,
+                                               set_read_status_cb, mas);
+       else
+               *err = -EBADR;
+
+       if (*err < 0)
+               return NULL;
+
        return mas;
 }
diff --git a/plugins/messages-dummy.c b/plugins/messages-dummy.c
index a47f143..78e20ae 100644
--- a/plugins/messages-dummy.c
+++ b/plugins/messages-dummy.c
@@ -353,6 +353,12 @@ int messages_update_inbox(void *session, messages_update_inbox_cb callback,
        return -ENOSYS;
 }

+int messages_set_read(void *session, const char *handle, uint8_t value,
+                               messages_set_read_cb callback, void *user_data)
+{
+       return -ENOSYS;
+}
+
 void messages_abort(void *s)
 {
        struct session *session = s;
diff --git a/plugins/messages-tracker.c b/plugins/messages-tracker.c
index 92c1767..1516dc7 100644
--- a/plugins/messages-tracker.c
+++ b/plugins/messages-tracker.c
@@ -327,6 +327,12 @@ int messages_update_inbox(void *session, messages_update_inbox_cb callback,
        return -ENOSYS;
 }

+int messages_set_read(void *session, const char *handle, uint8_t value,
+                               messages_set_read_cb callback, void *user_data)
+{
+       return -ENOSYS;
+}
+
 void messages_abort(void *session)
 {
 }
diff --git a/plugins/messages.h b/plugins/messages.h
index 669f7c2..45579d3 100644
--- a/plugins/messages.h
+++ b/plugins/messages.h
@@ -279,6 +279,19 @@ typedef void (*messages_update_inbox_cb)(void *session, int err,

 int messages_update_inbox(void *session, messages_update_inbox_cb callback,
                                                        void *user_data);
+/* Informs Message Server to modify read status of a given message.
+ *
+ * session: Backend session.
+ * handle: Unique identifier to the message.
+ * value: Indicates the new value of the read status for a given message.
+ * Callback shall be called for every read status update request
+ *     recieved from MCE.
+ * user_data: User data if any to be sent.
+ */
+typedef void (*messages_set_read_cb)(void *session, int err, void *user_data);
+
+int messages_set_read(void *session, const char *handle, uint8_t value,
+                               messages_set_read_cb callback, void *user_data);

 /* Aborts currently pending request.
  *
--
1.7.9.5
These 3 patches are now upstream, note that I did some changes and
added another patch on top of them to unify the callback as the
callbacks were doing exactly the same including update.


-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help