[PATCH hcidump 1/2 v1] AVRCP: Add parsing for SetAbsoluteVolume PDU

Subsystems: the rest

STALE5276d

3 messages, 2 authors, 2012-03-27 · open the first message on its own page

[PATCH hcidump 1/2 v1] AVRCP: Add parsing for SetAbsoluteVolume PDU

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-03-22 19:04:42

From: Luiz Augusto von Dentz <redacted>

---
v1: Fix 'absolut' typo, ignore reserved bit and print volume in percentage

 parser/avrcp.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/parser/avrcp.c b/parser/avrcp.c
index 643e494..a6d09c9 100644
--- a/parser/avrcp.c
+++ b/parser/avrcp.c

@@ -1201,6 +1201,23 @@ response:
 	}
 }
 
+static void avrcp_set_absolute_volume_dump(int level, struct frame *frm,
+						uint8_t ctype, uint16_t len)
+{
+	uint8_t value;
+
+	p_indent(level, frm);
+
+	if (len < 1) {
+		printf("PDU Malformed\n");
+		raw_dump(level, frm);
+		return;
+	}
+
+	value = get_u8(frm) & 0x7F;
+	printf("Volume: %.2f%% (%d/127)\n", value/1.27, value);
+}
+
 static void avrcp_pdu_dump(int level, struct frame *frm, uint8_t ctype)
 {
 	uint8_t pduid, pt;

@@ -1267,6 +1284,9 @@ static void avrcp_pdu_dump(int level, struct frame *frm, uint8_t ctype)
 	case AVRCP_REGISTER_NOTIFICATION:
 		avrcp_register_notification_dump(level + 1, frm, ctype, len);
 		break;
+	case AVRCP_SET_ABSOLUTE_VOLUME:
+		avrcp_set_absolute_volume_dump(level + 1, frm, ctype, len);
+		break;
 	default:
 		raw_dump(level, frm);
 	}

-- 
1.7.7.6

[PATCH hcidump 2/2 v1] AVRCP: Add parsing support for Volume Change notification

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-03-22 19:04:43

From: Luiz Augusto von Dentz <redacted>

---
v1: Print volume in percentage

 parser/avrcp.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/parser/avrcp.c b/parser/avrcp.c
index a6d09c9..850741b 100644
--- a/parser/avrcp.c
+++ b/parser/avrcp.c

@@ -1198,6 +1198,10 @@ response:
 						value2str(attr, value));
 		}
 		break;
+	case AVRCP_EVENT_VOLUME_CHANGED:
+		status = get_u8(frm) & 0x7F;
+		printf("Volume: %.2f%% (%d/127)\n", status/1.27, status);
+		break;
 	}
 }

-- 
1.7.7.6

Re: [PATCH hcidump 1/2 v1] AVRCP: Add parsing for SetAbsoluteVolume PDU

From: Johan Hedberg <hidden>
Date: 2012-03-27 11:41:37

Hi Luiz,

On Thu, Mar 22, 2012, Luiz Augusto von Dentz wrote:

From: Luiz Augusto von Dentz <redacted>

---
v1: Fix 'absolut' typo, ignore reserved bit and print volume in percentage

 parser/avrcp.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

Both patches have been applied. Thanks.

Johan

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help